https://github.com/arsenm approved this pull request.

LGTM. I'm not sure how this all ends up expanding, I was expecting to see the 
elementwise builtins used.

It would be great if we had update_cc_test_checks style testing for the 
resulting implementation 

https://github.com/llvm/llvm-project/pull/119596
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to