https://github.com/5chmidti commented:
> With current implementation you may run into issue where when setting custom > smart ptr, you won't have anymore support for shared_ptr. Other option would be to add "make-custom" check, and leave it unconfigured. Supporting multiple `make_x` would be best, as there may be more than one of these. > a bit unsure about this one, do you have any sample where there is usage of > multiple?! I don't, which is why I think this is not a blocker, but it would be better to have. While there was no issue I could find for adding the customization, I can see that someone may configure the check, wanting to add a second `make_x`. Either way, something like adding `misc-make-smart-ptr` should be done, in order to keep the functionality of the other two in place. I added the check to misc, but `readability` would fit as well. I wouldn't go for `modernize`, because in that context, it doesn't have to be a modernization. https://github.com/llvm/llvm-project/pull/117529 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
