================ @@ -6440,7 +6440,8 @@ const ToolChain &Driver::getToolChain(const ArgList &Args, TC = std::make_unique<toolchains::NVPTXToolChain>(*this, Target, Args); break; case llvm::Triple::AMDHSA: - TC = std::make_unique<toolchains::ROCMToolChain>(*this, Target, Args); + TC = std::make_unique<toolchains::ROCMToolChain>(*this, Target, Args, + Target.isOSWindows()); ---------------- jhuber6 wrote:
We do stuff like this in a *ton* of places, ``` clang/lib/Driver/ToolChains/Cuda.cpp 387: static_cast<const toolchains::NVPTXToolChain &>(getToolChain()); 533: static_cast<const toolchains::CudaToolChain &>(getToolChain()); 584: static_cast<const toolchains::NVPTXToolChain &>(getToolChain()); ``` https://github.com/llvm/llvm-project/pull/113628 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits