danielmarjamaki added inline comments.
================ Comment at: lib/StaticAnalyzer/Checkers/ValistChecker.cpp:189 + const auto *EReg = dyn_cast_or_null<ElementRegion>(Reg); + return EReg && VaListModelledAsArray ? EReg->getSuperRegion() : Reg; +} ---------------- I would personally recommend parentheses around EReg and VaListModelledAsArray to highlight the precedence. https://reviews.llvm.org/D30157 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
