Sirraide wrote:

> Should we come up with a new format specifier for the diagnostics engine so 
> that the author of the diagnostic can opt in to the additional formatting? My 
> concern with doing this in general is that some numbers really don't 
> need/want the separators so it seems like an opt-in would be better and if we 
> make the opt-in via the diagnostic string itself, nobody has to do anything 
> special to emit the diagnostic.

+1 for this approach.

https://github.com/llvm/llvm-project/pull/117763
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to