steakhal wrote:

> @steakhal and @NagyDonat , thanks for the comments. I'll address and update 
> the patch. Best

@vabridgers Please avoid force pushed. Prefer `merge` over `rebase` while doing 
the reviews. It's okay to have a sequence of commits fixing up certain 
behavior. Once the review is done, the PR is anyways squashed when merging. 
This helps to crossreference existing comments to your PR, that would GitHub 
loose track of every time you do a force push.

https://github.com/llvm/llvm-project/pull/117791
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to