================ @@ -656,18 +670,20 @@ BuiltinTypeDeclBuilder::addSimpleTemplateParams(ArrayRef<StringRef> Names, } BuiltinTypeDeclBuilder &BuiltinTypeDeclBuilder::addIncrementCounterMethod() { + using PH = BuiltinTypeMethodBuilder::PlaceHolder; return BuiltinTypeMethodBuilder(SemaRef, *this, "IncrementCounter", SemaRef.getASTContext().UnsignedIntTy) - .callBuiltin("__builtin_hlsl_buffer_update_counter", - {getConstantIntExpr(1)}) + .callBuiltin("__builtin_hlsl_buffer_update_counter", PH::Handle, + getConstantIntExpr(1)) ---------------- bogner wrote:
This feels too magical to me (and also it introduces an annoying ambiguity with a literal zero - is it an `int` or a null `Expr *`?) https://github.com/llvm/llvm-project/pull/117789 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits