stuij wrote:

I feel that in `useFramePointerForTargetByDef` fn, in general things are 
predicated first on platform and then on arch. That L85 arch switch statement 
seems to serve as a "these arches don't do anything special" early return.

It's up to interpretation, but putting the different Arm variants there seems 
less elegant to me (that might not be saying much..). I'd say let's leave it 
alone for now, and if the bare metal logic gets more impenetrable at some 
point, refactor.

 

https://github.com/llvm/llvm-project/pull/117140
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to