EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land.
LGTM after fixing inline comments. ================ Comment at: include/algorithm:3029 +#if _LIBCPP_STD_VER <= 14 || defined(_LIBCPP_ENABLE_CXX17_REMOVED_RANDOM_SHUFFLE) class _LIBCPP_TYPE_VIS __rs_default; ---------------- We should still expose these when building the library using `|| defined(_LIBCPP_BUILDING_LIBRARY)`. ================ Comment at: test/std/algorithms/alg.modifying.operations/alg.random.shuffle/random_shuffle.pass.cpp:11 // <algorithm> +// REQUIRES-ANY: c++98, c++03, c++11, c++14 ---------------- `REQUIRES-ANY` got removed. This should be written: ``` // REQUIRES: c++98 || c++03 || c++11 || c++14 ``` ================ Comment at: test/std/algorithms/alg.modifying.operations/alg.random.shuffle/random_shuffle_rand.pass.cpp:11 // <algorithm> +// REQUIRES-ANY: c++98, c++03, c++11, c++14 ---------------- `REQUIRES-ANY` got removed. This should be written: ``` // REQUIRES: c++98 || c++03 || c++11 || c++14 ``` https://reviews.llvm.org/D30045 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
