https://github.com/DavidTruby requested changes to this pull request.
Thanks for the patch! I don't think there's any actual shared ownership happening here so I think you could use `unique_ptr` instead, and that has lower overhead so would be preferable I think. I've left a comment as to why the patch fails the CI at the moment too. https://github.com/llvm/llvm-project/pull/116406 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
