jhuber6 wrote: > > Okay the problem with using `ASTContext` here is that it creates some > > recursive includes. ~I can do this by moving the check into `Type.cpp` > > instead, so this will be function call instead of being inlined.~ This > > would require a lot of extra stuff so I'm going to defer it unless we > > _really_ think it needs to be done. > > Can you just outline the slow path where you have to actually call the target > info hook?
It would require pushing some unrelated functions into `.cpp` files as well since the final check is shared between a lot of functions as shown in the diff, I'm not keen but if you think it's a blocker I can make it happen. Maybe we'd need it in the future if we wanted to control this with a language option? But for now I'm not sure it's worth the extra effort. https://github.com/llvm/llvm-project/pull/115777 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits