Meinersbur wrote: `cantFail` is not guaranteed to crash, e.g. in `-DLLVM_ENABLE_ASSERTIONS=OFF -DLLVM_UNREACHABLE_OPTIMIZE=ON`. I think this is fine for implementation code, for which `LLVM_UNREACHABLE_OPTIMIZE` is meant to improve performance, but for unittests such tests could silently pass in release builds.
Ideas: * `ASSERT_FALSE(errorToBool(Err))` * `if (Err) report_fatal_error(Err)` * Some new helper function https://github.com/llvm/llvm-project/pull/115863 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
