https://github.com/NagyDonat approved this pull request.

LGTM overall, feel free to add these NFC improvements.

My only comment is a suggestion to define the comparison logic with a 
higher-level approach -- but the existing code is also OK if you prefer that.

https://github.com/llvm/llvm-project/pull/115615
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to