boomanaiden154 wrote:

> I'm not concerned about how much time it takes to run. I want to add it to 
> clangFormat's dependencies if it doesn't run every time I do ninja 
> FormatTests.

I've updated the patch so that we only rerun the python script if the 
dependencies change. I've added a `.template` extension to the docs file so 
that it doesn't interfere with the copy in the build directory. It does not 
seem like there's an easy way to get CMake to copy the docs directory to the 
build directory while excluding that individual file. So renaming it prevents 
Sphinx from picking up the templatized version.

What's the point of adding it to the `FormatTests` target though? Just to 
ensure proper test coverage of the `dump_format_style.py` file? This seems like 
something that more should be covered by the documentation builds, which occur 
both precommit and postcommit with the precommit builds having reasonably nice 
UI.



https://github.com/llvm/llvm-project/pull/113739
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to