llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) <details> <summary>Changes</summary> Heterogenous lookups allow us to call find with StringRef, avoiding a temporary heap allocation of std::string. --- Full diff: https://github.com/llvm/llvm-project/pull/115259.diff 1 Files Affected: - (modified) clang/lib/Driver/ToolChains/HIPUtility.cpp (+5-6) ``````````diff diff --git a/clang/lib/Driver/ToolChains/HIPUtility.cpp b/clang/lib/Driver/ToolChains/HIPUtility.cpp index c8075cbfe36b35..3f81c3cb0f80e8 100644 --- a/clang/lib/Driver/ToolChains/HIPUtility.cpp +++ b/clang/lib/Driver/ToolChains/HIPUtility.cpp @@ -148,8 +148,8 @@ class HIPUndefinedFatBinSymbols { bool Verbose; std::set<std::string> FatBinSymbols; std::set<std::string> GPUBinHandleSymbols; - std::set<std::string> DefinedFatBinSymbols; - std::set<std::string> DefinedGPUBinHandleSymbols; + std::set<std::string, std::less<>> DefinedFatBinSymbols; + std::set<std::string, std::less<>> DefinedGPUBinHandleSymbols; const std::string FatBinPrefix = "__hip_fatbin"; const std::string GPUBinHandlePrefix = "__hip_gpubin_handle"; @@ -260,11 +260,10 @@ class HIPUndefinedFatBinSymbols { // Add undefined symbols if they are not in the defined sets if (isFatBinSymbol && - DefinedFatBinSymbols.find(Name.str()) == DefinedFatBinSymbols.end()) + DefinedFatBinSymbols.find(Name) == DefinedFatBinSymbols.end()) FatBinSymbols.insert(Name.str()); - else if (isGPUBinHandleSymbol && - DefinedGPUBinHandleSymbols.find(Name.str()) == - DefinedGPUBinHandleSymbols.end()) + else if (isGPUBinHandleSymbol && DefinedGPUBinHandleSymbols.find(Name) == + DefinedGPUBinHandleSymbols.end()) GPUBinHandleSymbols.insert(Name.str()); } } `````````` </details> https://github.com/llvm/llvm-project/pull/115259 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
