cierpuchaw added inline comments.
================ Comment at: clangd/DocumentStore.h:42 /// Delete a document from the store. - void removeDocument(StringRef Uri) { Docs.erase(Uri); } + void removeDocument(StringRef Uri) { Docs.erase(Uri); + for (const auto &Listener : Listeners) ---------------- cierpuchaw wrote: > Shouldn't this be called under a lock_guard? I should've reworded my comment before submitting it. By 'this' I'm referring to the 'Docs.erase()' part, not the whole function. https://reviews.llvm.org/D29886 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits