https://github.com/NagyDonat commented:

Thanks for implementing this cleanup commit!

I like that you ported the tests from the old checker to the tidy checks. 
However, as these test files are very large, perhaps it would be better to put 
these moved tests into stand-alone files instead of adding them at the end of 
existing files. (@ tidy developers: what would you prefer?)

Do I understand it correctly that the two tidy checkers report all the issues 
that were reported by alpha.core.IdenticalExpr? (Unfortunately github cannot 
show a clear diff between the old and new version of the moved code.)

https://github.com/llvm/llvm-project/pull/114715
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to