travkin79 wrote: Hi @chouzz,
Thank you very much for your PR draft. I checked your changes and have a few questions. Does the method AST.isConst(...) in your implementation mean a method declared with a const keyword (as intended in my [LSP PR](https://github.com/microsoft/language-server-protocol/pull/2003/files)) or do you mean some variable that is read-only? If you mean read-only, I think, you should use the read-only tag instead. Especially for C++ code, it would be great if the tags _declaration_ and _definition_ would also be set. I'm sure, clangd has these details already, since it uses these [modifiers e.g. for syntax highlighting](https://clangd.llvm.org/features#modifiers). Do you think, you could also set the _declaration_ and _definition_ tags? https://github.com/llvm/llvm-project/pull/113669 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
