https://github.com/5chmidti commented:
After these, this should be good to go in my opinion. --- For updating the PR branch: The whole branch gets squashed when merged anyway. A merge reduces the chance for pushing already existing commits that changed during rebase, causing other people to be tagged as well. Having additional commits for things done after the review has started instead of fixing up the original commit and force-pushing has the benefit of showing the incremental progress that GitHub does not correctly show when force-pushing. https://github.com/llvm/llvm-project/pull/102299 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
