https://github.com/5chmidti approved this pull request.
> I'm happy to document future changes beyond this check, but would like to > keep this PR's scope limited to just porting the original CSA based check to > a tidy check as much as possible. +1 --- > Also, I've not yet completed a full systems test on a large open source > project (like a clang build), but will do so after I get some indications > this PR is good to proceed with that. I'd like to minimize re-testing if > possible since it is not a small task. I've run the current implementation on `clang;clang-tools-extra` and found a single diagnosed issue for https://github.com/llvm/llvm-project/blob/d2e9532fe12dc2568f40c2648ff4bb3730141aed/llvm/tools/llvm-profgen/ProfileGenerator.cpp#L1292 and no crashes when running a debug build. Minus my new comments and maybe documenting the current limitations, this looks good to me. Do you plan to work on those improvements? Another approval would be nice, but I don't think it should be a blocker for this PR. https://github.com/llvm/llvm-project/pull/110471 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
