ioeric added inline comments.
================ Comment at: lib/Tooling/RefactoringCallbacks.cpp:160 +llvm::Expected<std::unique_ptr<ReplaceNodeWithTemplate>> +ReplaceNodeWithTemplate::create(StringRef FromId, StringRef ToTemplate) { + std::vector<TemplateElement> ParsedTemplate; ---------------- Is this covered in the test? ================ Comment at: unittests/Tooling/RefactoringCallbacksTest.cpp:101 + std::string Expected = "void f() { FOO }"; + ReplaceNodeWithTemplate Callback("id", "FOO"); + expectRewritten(Code, Expected, id("id", declStmt()), Callback); ---------------- Have you rerun the tests? Does this still build? https://reviews.llvm.org/D29621 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits