hekota wrote: > I have to admit I'm pretty confused about what the code is trying to do - the > ratio of new code added to new tests / changes to the tests is a bit > surprising. This means I can't look at the tests to try and understand what > the code change is for, but it also points at maybe there being a testing gap.
It is true that some of the information that is being gathered/calculated is not used anywhere yet, for example the size of the binding. It is likely going to be used on the future used when we implement implicit bindings or overlapping binding diagnostics, and maybe it will change to be something else. The question is - if it cannot be tested, should it be included now and complete https://github.com/llvm/llvm-project/issues/110719, or should it be added later as needed in the future binding-related work? @bogner - do you have an opinion on this? @damyanp thinks it should be removed. I'm ok with replacing the size calculations with FIXME's. https://github.com/llvm/llvm-project/pull/111203 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
