https://github.com/5chmidti commented:

This is 'basically' ready. Sorry for the delay.

---

As stated in the comment, I've benchmarked the RAV and matcher-based solution, 
and they perform the same. So the actual (performance) benefit of using the RAV 
does not actually exist. I'd suggest using the matcher based solution instead, 
as matchers should be the preferred tool in clang-tidy, and the implementation 
is much shorter/easier to understand at a glance.

---

I'd like to get a second approval in before we merge this.

https://github.com/llvm/llvm-project/pull/102299
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to