jurahul wrote: I will add getDeclaration back and mark it deprecated. What’s the timeframe for deprecation thought? A couple of weeks? Because I do want to add back the getDeclaration with different semantics. Unless we go with @nikic’s recommendation of getDeclarationIfExists. I am going to wait for @nikic’s response before any more changes here.
On Sat, Oct 12, 2024 at 6:53 PM Yingwei Zheng ***@***.***> wrote: > TBH I am wondering if we should revert this rename. I don't think it's a > good idea to reuse getDeclaration with substantially different semantics, > and if we're not reusing it, then there's not much point to rename... > > Instead of having getOrInsertDeclaration + getDeclaration with a meaning > inversion, we can have getDeclaration and getDeclarationIfExists without > the inversion. > > I'd like to revert this change, or just add Intrinsic::getDeclaration > back and mark it as deprecated. I have encountered a build error on Alive2. > > — > Reply to this email directly, view it on GitHub > <https://github.com/llvm/llvm-project/pull/111752#issuecomment-2408780685>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/APRMUB5DATS3NVLAPVXRNITZ3HHANAVCNFSM6AAAAABPVHZ3QGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYG44DANRYGU> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > https://github.com/llvm/llvm-project/pull/111752 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
