================ @@ -58,7 +58,9 @@ // Check __has_constexpr_builtin #if !__has_constexpr_builtin(__builtin_fmax) || \ - !__has_constexpr_builtin(__builtin_fmin) + !__has_constexpr_builtin(__builtin_fmin) || \ + !__has_constexpr_builtin(__builtin_fmaximum_num) || \ + !__has_constexpr_builtin(__builtin_fmaximum_num) ---------------- graphite-app[bot] wrote:
There appears to be a duplicate check for `__builtin_fmaximum_num`. The second occurrence should likely be `__builtin_fminimum_num` instead to cover both new intrinsics. Please review and update this condition to ensure all intended builtin functions are properly tested. *Spotted by [Graphite Reviewer](https://app.graphite.dev/graphite-reviewer/?org=llvm&ref=ai-review-comment)*<i class='graphite__hidden'><br /><br />Is this helpful? React 👍 or 👎 to let us know.</i> https://github.com/llvm/llvm-project/pull/96281 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
