================ @@ -292,21 +292,21 @@ class FileManager : public RefCountedBase<FileManager> { /// MemoryBuffer if successful, otherwise returning null. llvm::ErrorOr<std::unique_ptr<llvm::MemoryBuffer>> getBufferForFile(FileEntryRef Entry, bool isVolatile = false, - bool RequiresNullTerminator = true, + bool RequiresNullTerminator = true, bool IsText = true, ---------------- kadircet wrote:
can you add some comments explaining what `IsText` is about and when it should be set to `false`? also can you make it the last parameter ? https://github.com/llvm/llvm-project/pull/111723 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits