================
@@ -47,6 +47,14 @@ if(${LLVM_NATIVE_ARCH} MATCHES 
"^(AArch64|Hexagon|Sparc|SystemZ)$")
   set(RUN_PYTHON_TESTS FALSE)
 endif()
 
+# Tests will fail if cross-compiling for a different target, as tests will try
+# to use the host Python3_EXECUTABLE and make FFI calls to functions in target
+# libraries.
+if(CMAKE_CROSS_COMPILING)
----------------
AaronBallman wrote:

If I understand correctly, I think we probably do want a FIXME for clarity 
because we'd ultimately like the python tests to work in a cross-compile 
situation because I don't think there should be a distinction between running 
the C binding tests and the Python binding tests. Potentially we might be able 
to do this by hooking them in to the lit-orchestrated tests and using 
`LIT_ARGS` the same as the Clang tests?

Regardless, nothing has to be done for now beyond adding a FIXME comment; and 
if we decide the complexity is too great when digging into doing that effort, 
we can always walk back the comment.

https://github.com/llvm/llvm-project/pull/111657
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to