gamesh411 wrote: > Usually its hard to see how the implementation changes if anyways all the > surrounding code moves. For such changes, if the change is large (like in > this case, its a 2k+ diff), it feels better to review the individual commits > instead of everything all at once. If we do that right, the bulk of the > change will be attributed to a handful of NFC mechanical changes, and I could > focus on whats left.
We can do that. I will just create separate PRs for these commits, emphasizing in each one whether they are NFCs or the key points where they deviate from being NFCs. https://github.com/llvm/llvm-project/pull/109636 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
