llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) <details> <summary>Changes</summary> --- Full diff: https://github.com/llvm/llvm-project/pull/111273.diff 1 Files Affected: - (modified) clang/lib/AST/ByteCode/Program.cpp (+5-7) ``````````diff diff --git a/clang/lib/AST/ByteCode/Program.cpp b/clang/lib/AST/ByteCode/Program.cpp index 969f523db51dfe..23245a66b578ae 100644 --- a/clang/lib/AST/ByteCode/Program.cpp +++ b/clang/lib/AST/ByteCode/Program.cpp @@ -284,15 +284,13 @@ Record *Program::getOrCreateRecord(const RecordDecl *RD) { if (!RD->isCompleteDefinition()) return nullptr; - // Deduplicate records. - if (auto It = Records.find(RD); It != Records.end()) + // Return an existing record if available. Otherwise, we insert nullptr now + // and replace that later, so recursive calls to this function with the same + // RecordDecl don't run into infinite recursion. + auto [It, Inserted] = Records.try_emplace(RD); + if (!Inserted) return It->second; - // We insert nullptr now and replace that later, so recursive calls - // to this function with the same RecordDecl don't run into - // infinite recursion. - Records.insert({RD, nullptr}); - // Number of bytes required by fields and base classes. unsigned BaseSize = 0; // Number of bytes required by virtual base. `````````` </details> https://github.com/llvm/llvm-project/pull/111273 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
