Author: Rahul Joshi Date: 2024-10-01T10:45:57-07:00 New Revision: cea09886c22f6f1b745a3d9e04494ae63e25cb8b
URL: https://github.com/llvm/llvm-project/commit/cea09886c22f6f1b745a3d9e04494ae63e25cb8b DIFF: https://github.com/llvm/llvm-project/commit/cea09886c22f6f1b745a3d9e04494ae63e25cb8b.diff LOG: [Clang][TableGen] Change OptionDoc Emitter to use const Record * (#110592) This is a part of effort to have better const correctness in TableGen backends: https://discourse.llvm.org/t/psa-planned-changes-to-tablegen-getallderiveddefinitions-api-potential-downstream-breakages/81089 Added: Modified: clang/utils/TableGen/ClangOptionDocEmitter.cpp Removed: ################################################################################ diff --git a/clang/utils/TableGen/ClangOptionDocEmitter.cpp b/clang/utils/TableGen/ClangOptionDocEmitter.cpp index d8a467fd41a2ef..424d582f762282 100644 --- a/clang/utils/TableGen/ClangOptionDocEmitter.cpp +++ b/clang/utils/TableGen/ClangOptionDocEmitter.cpp @@ -282,11 +282,12 @@ void emitOptionName(StringRef Prefix, const Record *Option, raw_ostream &OS) { } } - emitOptionWithArgs(Prefix, Option, std::vector<StringRef>(Args.begin(), Args.end()), OS); + emitOptionWithArgs(Prefix, Option, + std::vector<StringRef>(Args.begin(), Args.end()), OS); auto AliasArgs = Option->getValueAsListOfStrings("AliasArgs"); if (!AliasArgs.empty()) { - Record *Alias = Option->getValueAsDef("Alias"); + const Record *Alias = Option->getValueAsDef("Alias"); OS << " (equivalent to "; emitOptionWithArgs( Alias->getValueAsListOfStrings("Prefixes").front(), Alias, @@ -363,9 +364,8 @@ void emitOption(const DocumentedOption &Option, const Record *DocInfo, // Prefer a program specific help string. // This is a list of (visibilities, string) pairs. - std::vector<Record *> VisibilitiesHelp = - R->getValueAsListOfDefs("HelpTextsForVariants"); - for (Record *VisibilityHelp : VisibilitiesHelp) { + for (const Record *VisibilityHelp : + R->getValueAsListOfDefs("HelpTextsForVariants")) { // This is a list of visibilities. ArrayRef<Init *> Visibilities = VisibilityHelp->getValueAsListInit("Visibilities")->getValues(); _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
