Author: Congcong Cai Date: 2024-09-30T21:25:22+08:00 New Revision: 282fc93f09154c58a9b819ba7beaaba6c5e6ad8a
URL: https://github.com/llvm/llvm-project/commit/282fc93f09154c58a9b819ba7beaaba6c5e6ad8a DIFF: https://github.com/llvm/llvm-project/commit/282fc93f09154c58a9b819ba7beaaba6c5e6ad8a.diff LOG: [clang-tidy][NFC] optimize unused using decls performance (#110200) Improve performance by moving the check forward to the matching stage Added: Modified: clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp Removed: ################################################################################ diff --git a/clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp b/clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp index 90b317527ee410..1ff61bae46b1ed 100644 --- a/clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp +++ b/clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp @@ -25,6 +25,13 @@ AST_MATCHER_P(DeducedTemplateSpecializationType, refsToTemplatedDecl, return false; } +AST_MATCHER_P(Type, asTagDecl, clang::ast_matchers::internal::Matcher<TagDecl>, + DeclMatcher) { + if (const TagDecl *ND = Node.getAsTagDecl()) + return DeclMatcher.matches(*ND, Finder, Builder); + return false; +} + } // namespace // A function that helps to tell whether a TargetDecl in a UsingDecl will be @@ -61,7 +68,8 @@ void UnusedUsingDeclsCheck::registerMatchers(MatchFinder *Finder) { Finder->addMatcher(userDefinedLiteral().bind("used"), this); Finder->addMatcher( loc(elaboratedType(unless(hasQualifier(nestedNameSpecifier())), - hasUnqualifiedDesugaredType(type().bind("usedType")))), + hasUnqualifiedDesugaredType( + type(asTagDecl(tagDecl().bind("used")))))), this); // Cases where we can identify the UsingShadowDecl directly, rather than // just its target. @@ -139,12 +147,6 @@ void UnusedUsingDeclsCheck::check(const MatchFinder::MatchResult &Result) { return; } - if (const auto *T = Result.Nodes.getNodeAs<Type>("usedType")) { - if (const auto *ND = T->getAsTagDecl()) - RemoveNamedDecl(ND); - return; - } - if (const auto *UsedShadow = Result.Nodes.getNodeAs<UsingShadowDecl>("usedShadow")) { removeFromFoundDecls(UsedShadow->getTargetDecl()); _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
