================
@@ -634,7 +634,7 @@ struct ConvertConstructorToDeductionGuideTransform {
 
 // Find all template parameters that appear in the given DeducedArgs.
 // Return the indices of the template parameters in the TemplateParams.
-SmallVector<unsigned> TemplateParamsReferencedInTemplateArgumentList(
+llvm::SmallSet<unsigned, 8> TemplateParamsReferencedInTemplateArgumentList(
----------------
hokein wrote:

The returned vector is a sorted indices of the referenced template parameters, 
and the call site implicitly [depends 
on](https://github.com/llvm/llvm-project/blob/main/clang/lib/Sema/SemaTemplateDeductionGuide.cpp#L1050-L1051)
 this order. Changing it could disrupt the indexing of transformed template 
parameters.

How about keeping it unchanged and creating a SmallSet based on the return 
result for your use case?

https://github.com/llvm/llvm-project/pull/98788
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to