https://github.com/ilovepi commented:
I think we still have a ways to go. There's quite a few comments that haven't been addressed, and I think there's still a need to describe the algorithms in the parser and rendering. Some of the code has gotten quite long/large, which is often fine, but I think it may help to break some of those larger functions down a bit more. For instance, there's a lot of redundancy in some of the switch cases. Templates and helper functions could make a big difference in how complicated this patch is. Also, please move the tool support into its own patch. This one is large enough as is, and should likely be broken up further. https://github.com/llvm/llvm-project/pull/105893 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
