kazutakahirata wrote:

> Next time please provide a better summary for your PR. This is super 
> important for downstream folks debugging build breaks. In general this is 
> important for reviews to compare what they expect with the actual diff.
> 
> 
> 
> In this case something like "replace the use of conditional operator on 
> std::optional w/ value_or" would have been sufficient. 
> 
> 
> 
> Thank you

Ack.

https://github.com/llvm/llvm-project/pull/109894
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to