================ @@ -0,0 +1,48 @@ +//===--- TemplateVirtualMemberFunctionCheck.cpp - clang-tidy --------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#include "TemplateVirtualMemberFunctionCheck.h" +#include "clang/ASTMatchers/ASTMatchFinder.h" + +using namespace clang::ast_matchers; + +namespace clang::tidy::portability { + +void TemplateVirtualMemberFunctionCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher(classTemplateSpecializationDecl().bind("specialization"), + this); +} + +void TemplateVirtualMemberFunctionCheck::check( + const MatchFinder::MatchResult &Result) { + const auto *MatchedDecl = + Result.Nodes.getNodeAs<ClassTemplateSpecializationDecl>("specialization"); + + if (MatchedDecl->isExplicitSpecialization()) + return; ---------------- 5chmidti wrote:
Actually, see https://godbolt.org/z/Wv91aaTcx ```c++ template <typename T, typename U = T> struct CrossPlatformError { virtual ~CrossPlatformError() = default; static void used() {} virtual void unused() { T MSVCError = this; }; }; template <typename U> struct CrossPlatformError<int, U> { virtual ~CrossPlatformError() = default; static void used() {} virtual void different_unused() { U MSVCError = this; }; }; int main() { CrossPlatformError<int>::used(); return 0; } ``` partial specializations could introduce the same issue, and only fully specialized class templates should be ignored. https://github.com/llvm/llvm-project/pull/110099 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
