Author: Congcong Cai Date: 2024-09-24T07:25:07+08:00 New Revision: eca5949031c31fe5ff5ad7a5df07bbce13379108
URL: https://github.com/llvm/llvm-project/commit/eca5949031c31fe5ff5ad7a5df07bbce13379108 DIFF: https://github.com/llvm/llvm-project/commit/eca5949031c31fe5ff5ad7a5df07bbce13379108.diff LOG: [codegen][NFC] add static mark for internal usage variable and function (#109431) Detect by clang-tidy misc-use-internal-linkage Added: Modified: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGStmtOpenMP.cpp clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/SanitizerMetadata.cpp Removed: ################################################################################ diff --git a/clang/lib/CodeGen/CGBuiltin.cpp b/clang/lib/CodeGen/CGBuiltin.cpp index fab055213261ed..942468204f054c 100644 --- a/clang/lib/CodeGen/CGBuiltin.cpp +++ b/clang/lib/CodeGen/CGBuiltin.cpp @@ -587,9 +587,10 @@ static Value *emitCallMaybeConstrainedFPBuiltin(CodeGenFunction &CGF, // matching the argument type. It is assumed that only the first argument is // overloaded. template <unsigned N> -Value *emitBuiltinWithOneOverloadedType(CodeGenFunction &CGF, const CallExpr *E, - unsigned IntrinsicID, - llvm::StringRef Name = "") { +static Value *emitBuiltinWithOneOverloadedType(CodeGenFunction &CGF, + const CallExpr *E, + unsigned IntrinsicID, + llvm::StringRef Name = "") { static_assert(N, "expect non-empty argument"); SmallVector<Value *, N> Args; for (unsigned I = 0; I < N; ++I) @@ -18569,7 +18570,7 @@ llvm::Value *CodeGenFunction::EmitScalarOrConstFoldImmArg(unsigned ICEArguments, } // Return dot product intrinsic that corresponds to the QT scalar type -Intrinsic::ID getDotProductIntrinsic(CGHLSLRuntime &RT, QualType QT) { +static Intrinsic::ID getDotProductIntrinsic(CGHLSLRuntime &RT, QualType QT) { if (QT->isFloatingType()) return RT.getFDotIntrinsic(); if (QT->isSignedIntegerType()) diff --git a/clang/lib/CodeGen/CGOpenMPRuntime.cpp b/clang/lib/CodeGen/CGOpenMPRuntime.cpp index 7a94c4d522d0c3..8593cb5ffdd97d 100644 --- a/clang/lib/CodeGen/CGOpenMPRuntime.cpp +++ b/clang/lib/CodeGen/CGOpenMPRuntime.cpp @@ -1490,7 +1490,7 @@ llvm::Type *CGOpenMPRuntime::getKmpc_MicroPointerTy() { return llvm::PointerType::getUnqual(Kmpc_MicroTy); } -llvm::OffloadEntriesInfoManager::OMPTargetDeviceClauseKind +static llvm::OffloadEntriesInfoManager::OMPTargetDeviceClauseKind convertDeviceClause(const VarDecl *VD) { std::optional<OMPDeclareTargetDeclAttr::DevTypeTy> DevTy = OMPDeclareTargetDeclAttr::getDeviceType(VD); @@ -1513,7 +1513,7 @@ convertDeviceClause(const VarDecl *VD) { } } -llvm::OffloadEntriesInfoManager::OMPTargetGlobalVarEntryKind +static llvm::OffloadEntriesInfoManager::OMPTargetGlobalVarEntryKind convertCaptureClause(const VarDecl *VD) { std::optional<OMPDeclareTargetDeclAttr::MapTypeTy> MapType = OMPDeclareTargetDeclAttr::isDeclareTargetDeclaration(VD); @@ -8836,7 +8836,7 @@ static ValueDecl *getDeclFromThisExpr(const Expr *E) { /// Emit a string constant containing the names of the values mapped to the /// offloading runtime library. -llvm::Constant * +static llvm::Constant * emitMappingInformation(CodeGenFunction &CGF, llvm::OpenMPIRBuilder &OMPBuilder, MappableExprsHandler::MappingExprInfo &MapExprs) { @@ -9450,8 +9450,8 @@ static llvm::Value *emitDeviceID( return DeviceID; } -llvm::Value *emitDynCGGroupMem(const OMPExecutableDirective &D, - CodeGenFunction &CGF) { +static llvm::Value *emitDynCGGroupMem(const OMPExecutableDirective &D, + CodeGenFunction &CGF) { llvm::Value *DynCGroupMem = CGF.Builder.getInt32(0); if (auto *DynMemClause = D.getSingleClause<OMPXDynCGroupMemClause>()) { diff --git a/clang/lib/CodeGen/CGStmtOpenMP.cpp b/clang/lib/CodeGen/CGStmtOpenMP.cpp index b11df8334766a8..71a27d0c6bc1fb 100644 --- a/clang/lib/CodeGen/CGStmtOpenMP.cpp +++ b/clang/lib/CodeGen/CGStmtOpenMP.cpp @@ -2734,8 +2734,8 @@ GetAlignedMapping(const OMPLoopDirective &S, CodeGenFunction &CGF) { // Pass OMPLoopDirective (instead of OMPSimdDirective) to make this function // available for "loop bind(thread)", which maps to "simd". -void emitOMPSimdDirective(const OMPLoopDirective &S, CodeGenFunction &CGF, - CodeGenModule &CGM) { +static void emitOMPSimdDirective(const OMPLoopDirective &S, + CodeGenFunction &CGF, CodeGenModule &CGM) { bool UseOMPIRBuilder = CGM.getLangOpts().OpenMPIRBuilder && isSimdSupportedByOpenMPIRBuilder(S); if (UseOMPIRBuilder) { @@ -3987,8 +3987,8 @@ convertClauseKindToSchedKind(OpenMPScheduleClauseKind ScheduleClauseKind) { // Pass OMPLoopDirective (instead of OMPForDirective) to make this function // available for "loop bind(parallel)", which maps to "for". -void emitOMPForDirective(const OMPLoopDirective &S, CodeGenFunction &CGF, - CodeGenModule &CGM, bool HasCancel) { +static void emitOMPForDirective(const OMPLoopDirective &S, CodeGenFunction &CGF, + CodeGenModule &CGM, bool HasCancel) { bool HasLastprivates = false; bool UseOMPIRBuilder = CGM.getLangOpts().OpenMPIRBuilder && isForSupportedByOpenMPIRBuilder(S, HasCancel); @@ -5447,7 +5447,7 @@ void CodeGenFunction::EmitOMPTaskwaitDirective(const OMPTaskwaitDirective &S) { CGM.getOpenMPRuntime().emitTaskwaitCall(*this, S.getBeginLoc(), Data); } -bool isSupportedByOpenMPIRBuilder(const OMPTaskgroupDirective &T) { +static bool isSupportedByOpenMPIRBuilder(const OMPTaskgroupDirective &T) { return T.clauses().empty(); } @@ -5968,8 +5968,9 @@ void CodeGenFunction::EmitOMPDistributeLoop(const OMPLoopDirective &S, // Pass OMPLoopDirective (instead of OMPDistributeDirective) to make this // function available for "loop bind(teams)", which maps to "distribute". -void emitOMPDistributeDirective(const OMPLoopDirective &S, CodeGenFunction &CGF, - CodeGenModule &CGM) { +static void emitOMPDistributeDirective(const OMPLoopDirective &S, + CodeGenFunction &CGF, + CodeGenModule &CGM) { auto &&CodeGen = [&S](CodeGenFunction &CGF, PrePostActionTy &) { CGF.EmitOMPDistributeLoop(S, emitOMPLoopBodyWithStopPoint, S.getInc()); }; diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp index 17b82b205063d4..d53d47979f29fb 100644 --- a/clang/lib/CodeGen/CodeGenModule.cpp +++ b/clang/lib/CodeGen/CodeGenModule.cpp @@ -784,8 +784,9 @@ getLLVMVisibility(clang::LangOptions::VisibilityFromDLLStorageClassKinds K) { llvm_unreachable("unknown option value!"); } -void setLLVMVisibility(llvm::GlobalValue &GV, - std::optional<llvm::GlobalValue::VisibilityTypes> V) { +static void +setLLVMVisibility(llvm::GlobalValue &GV, + std::optional<llvm::GlobalValue::VisibilityTypes> V) { if (!V) return; @@ -4224,8 +4225,8 @@ TargetMVPriority(const TargetInfo &TI, // in the cases of CPUDispatch, this causes issues. This also makes sure we // work with internal linkage functions, so that the same function name can be // used with internal linkage in multiple TUs. -llvm::GlobalValue::LinkageTypes getMultiversionLinkage(CodeGenModule &CGM, - GlobalDecl GD) { +static llvm::GlobalValue::LinkageTypes +getMultiversionLinkage(CodeGenModule &CGM, GlobalDecl GD) { const FunctionDecl *FD = cast<FunctionDecl>(GD.getDecl()); if (FD->getFormalLinkage() == Linkage::Internal) return llvm::GlobalValue::InternalLinkage; diff --git a/clang/lib/CodeGen/SanitizerMetadata.cpp b/clang/lib/CodeGen/SanitizerMetadata.cpp index afa104a654dab4..5b212a163611dc 100644 --- a/clang/lib/CodeGen/SanitizerMetadata.cpp +++ b/clang/lib/CodeGen/SanitizerMetadata.cpp @@ -27,7 +27,7 @@ static bool isAsanHwasanOrMemTag(const SanitizerSet &SS) { SanitizerKind::HWAddress | SanitizerKind::MemTag); } -SanitizerMask expandKernelSanitizerMasks(SanitizerMask Mask) { +static SanitizerMask expandKernelSanitizerMasks(SanitizerMask Mask) { if (Mask & (SanitizerKind::Address | SanitizerKind::KernelAddress)) Mask |= SanitizerKind::Address | SanitizerKind::KernelAddress; // Note: KHWASan doesn't support globals. _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
