Author: alexfh Date: Tue Jan 24 06:42:26 2017 New Revision: 292926 URL: http://llvm.org/viewvc/llvm-project?rev=292926&view=rev Log: [clang-tidy] Fix NOLINT test
Summary: Test cases I've added in review D26218 were too brittle and weren't working properly. This patch fixes this. Reviewers: alexfh Reviewed By: alexfh Subscribers: cfe-commits Patch by Nikita Kakuev! Differential Revision: https://reviews.llvm.org/D26466 Modified: clang-tools-extra/trunk/test/clang-tidy/nolint.cpp Modified: clang-tools-extra/trunk/test/clang-tidy/nolint.cpp URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/nolint.cpp?rev=292926&r1=292925&r2=292926&view=diff ============================================================================== --- clang-tools-extra/trunk/test/clang-tidy/nolint.cpp (original) +++ clang-tools-extra/trunk/test/clang-tidy/nolint.cpp Tue Jan 24 06:42:26 2017 @@ -1,5 +1,12 @@ // RUN: %check_clang_tidy %s google-explicit-constructor,clang-diagnostic-unused-variable,clang-analyzer-core.UndefinedBinaryOperatorResult %t -- -extra-arg=-Wunused-variable -- -I%S/Inputs/nolint +#include "trigger_warning.h" +void I(int& Out) { + int In; + A1(In, Out); +} +// CHECK-MESSAGES-NOT: trigger_warning.h:{{.*}} warning +// CHECK-MESSAGES-NOT: :[[@LINE-4]]:{{.*}} note class A { A(int i); }; // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: single-argument constructors must be marked explicit @@ -28,12 +35,4 @@ MACRO_NOLINT #define DOUBLE_MACRO MACRO(H) // NOLINT DOUBLE_MACRO -#include "trigger_warning.h" -void I(int& Out) { - int In; - A1(In, Out); -} -// CHECK-NOT: trigger_warning.h:{{.*}} warning: The left operand of '>' is a garbage value -// CHECK-NOT: :[[@LINE-4]]:{{.*}} note - // CHECK-MESSAGES: Suppressed 8 warnings (8 NOLINT) _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
