mehdi_amini added inline comments.

================
Comment at: clang/include/clang/CodeGen/BackendUtil.h:51
+  llvm::Expected<llvm::BitcodeModule>
+  FindThinLTOModule(llvm::MemoryBufferRef MBRef);
 }
----------------
Indentation seems strange?


================
Comment at: clang/lib/CodeGen/CodeGenAction.cpp:841
 
+std::unique_ptr<llvm::Module> CodeGenAction::loadModule(MemoryBufferRef MBRef) 
{
+  CompilerInstance &CI = getCompilerInstance();
----------------
Can you extract this function in a separate patch? I feel the diff could be a 
lot more contained here.



https://reviews.llvm.org/D29067



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to