[PATCH] D28889: Change where we handle arg-dependent diagnose_if attributes

[Richard Smith via Phabricator via cfe-commits]

rsmith added inline comments.


================
Comment at: include/clang/Sema/Overload.h:758
     /// instead.
+    /// FIXME: Now that it only alloates ImplicitConversionSequences, do we 
want
+    /// to un-generalize this?
----------------
Typo "alloates"


================
Comment at: lib/Sema/SemaChecking.cpp:2490
             CallType);
+  diagnoseArgDependentDiagnoseIfAttrs(FDecl, /*ThisArg=*/nullptr, Args, Loc);
 }
----------------
Can this be moved inside `checkCall`?


https://reviews.llvm.org/D28889



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits