klimek added inline comments.
================
Comment at: lib/Format/BreakableToken.h:55-56
+/// been reformatted, and
+/// - replaceWhitespaceBefore, for executing the reflow using a whitespace
+/// manager.
+///
----------------
Shouldn't that be called insertBreakBefore for consistency then?
Also, perhaps we want to rename replaceWhitespace to cleanupWhitespace or
compressWhitespace or something...
================
Comment at: lib/Format/ContinuationIndenter.cpp:1158-1159
+ CommentPragmasRegex.match(Current.TokenText.substr(2)) ||
+ Current.TokenText.substr(2).ltrim().startswith("clang-format on") ||
+ Current.TokenText.substr(2).ltrim().startswith("clang-format off"))
return addMultilineToken(Current, State);
----------------
Generally, we shouldn't need those here, as those should be part of the
Token.Finalized state.
================
Comment at: lib/Format/ContinuationIndenter.cpp:1220
+ RemainingTokenColumns = RemainingTokenColumns + 1 - Split.second;
+ ReflowInProgress = true;
if (!DryRun)
----------------
Explain this part in a comment.
https://reviews.llvm.org/D28764
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
