llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-static-analyzer-1 Author: Congcong Cai (HerrCai0907) <details> <summary>Changes</summary> Detected by `misc-use-internal-linkage` --- Full diff: https://github.com/llvm/llvm-project/pull/108759.diff 9 Files Affected: - (modified) clang/lib/StaticAnalyzer/Checkers/MoveChecker.cpp (+1) - (modified) clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp (+3-2) - (modified) clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp (+2-2) - (modified) clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp (+3-3) - (modified) clang/lib/StaticAnalyzer/Checkers/StdVariantChecker.cpp (+2-2) - (modified) clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp (+1-1) - (modified) clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp (+4-3) - (modified) clang/lib/StaticAnalyzer/Core/LoopUnrolling.cpp (+3-3) - (modified) clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp (+2-2) ``````````diff diff --git a/clang/lib/StaticAnalyzer/Checkers/MoveChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/MoveChecker.cpp index 5240352a9bd2f9..2107b9c4f5b323 100644 --- a/clang/lib/StaticAnalyzer/Checkers/MoveChecker.cpp +++ b/clang/lib/StaticAnalyzer/Checkers/MoveChecker.cpp @@ -22,6 +22,7 @@ #include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h" #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" #include "llvm/ADT/StringSet.h" +#include "Move.h" using namespace clang; using namespace ento; diff --git a/clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp b/clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp index f73c9007c18380..456132ef0a0a22 100644 --- a/clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp +++ b/clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp @@ -635,8 +635,9 @@ class VarBindingsCollector : public StoreManager::BindingsHandler { }; } // namespace -Bindings getAllVarBindingsForSymbol(ProgramStateManager &Manager, - const ExplodedNode *Node, SymbolRef Sym) { +static Bindings getAllVarBindingsForSymbol(ProgramStateManager &Manager, + const ExplodedNode *Node, + SymbolRef Sym) { Bindings Result; VarBindingsCollector Collector{Sym, Result}; while (Result.empty() && Node) { diff --git a/clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp b/clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp index 505020d4bb39fa..321388ad857f44 100644 --- a/clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp +++ b/clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp @@ -241,7 +241,7 @@ bool SmartPtrModeling::isBoolConversionMethod(const CallEvent &Call) const { constexpr llvm::StringLiteral BASIC_OSTREAM_NAMES[] = {"basic_ostream"}; -bool isStdBasicOstream(const Expr *E) { +static bool isStdBasicOstream(const Expr *E) { const auto *RD = E->getType()->getAsCXXRecordDecl(); return hasStdClassWithName(RD, BASIC_OSTREAM_NAMES); } @@ -250,7 +250,7 @@ static bool isStdFunctionCall(const CallEvent &Call) { return Call.getDecl() && Call.getDecl()->getDeclContext()->isStdNamespace(); } -bool isStdOstreamOperatorCall(const CallEvent &Call) { +static bool isStdOstreamOperatorCall(const CallEvent &Call) { if (Call.getNumArgs() != 2 || !isStdFunctionCall(Call)) return false; const auto *FC = dyn_cast<SimpleFunctionCall>(&Call); diff --git a/clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp index 5394c2257514dc..1d58e1b02785d6 100644 --- a/clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp +++ b/clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp @@ -305,7 +305,7 @@ static const MemSpaceRegion *getStackOrGlobalSpaceRegion(const MemRegion *R) { return nullptr; } -const MemRegion *getOriginBaseRegion(const MemRegion *Reg) { +const static MemRegion *getOriginBaseRegion(const MemRegion *Reg) { Reg = Reg->getBaseRegion(); while (const auto *SymReg = dyn_cast<SymbolicRegion>(Reg)) { const auto *OriginReg = SymReg->getSymbol()->getOriginRegion(); @@ -316,7 +316,7 @@ const MemRegion *getOriginBaseRegion(const MemRegion *Reg) { return Reg; } -std::optional<std::string> printReferrer(const MemRegion *Referrer) { +static std::optional<std::string> printReferrer(const MemRegion *Referrer) { assert(Referrer); const StringRef ReferrerMemorySpace = [](const MemSpaceRegion *Space) { if (isa<StaticGlobalSpaceRegion>(Space)) @@ -354,7 +354,7 @@ std::optional<std::string> printReferrer(const MemRegion *Referrer) { /// Check whether \p Region refers to a freshly minted symbol after an opaque /// function call. -bool isInvalidatedSymbolRegion(const MemRegion *Region) { +static bool isInvalidatedSymbolRegion(const MemRegion *Region) { const auto *SymReg = Region->getAs<SymbolicRegion>(); if (!SymReg) return false; diff --git a/clang/lib/StaticAnalyzer/Checkers/StdVariantChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/StdVariantChecker.cpp index 19877964bd900a..a026735bc107fe 100644 --- a/clang/lib/StaticAnalyzer/Checkers/StdVariantChecker.cpp +++ b/clang/lib/StaticAnalyzer/Checkers/StdVariantChecker.cpp @@ -31,7 +31,7 @@ REGISTER_MAP_WITH_PROGRAMSTATE(VariantHeldTypeMap, const MemRegion *, QualType) namespace clang::ento::tagged_union_modeling { -const CXXConstructorDecl * +static const CXXConstructorDecl * getConstructorDeclarationForCall(const CallEvent &Call) { const auto *ConstructorCall = dyn_cast<CXXConstructorCall>(&Call); if (!ConstructorCall) @@ -76,7 +76,7 @@ bool isMoveAssignmentCall(const CallEvent &Call) { return AsMethodDecl->isMoveAssignmentOperator(); } -bool isStdType(const Type *Type, llvm::StringRef TypeName) { +static bool isStdType(const Type *Type, llvm::StringRef TypeName) { auto *Decl = Type->getAsRecordDecl(); if (!Decl) return false; diff --git a/clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp b/clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp index 5c10e757244d7f..b0563b6c070f1f 100644 --- a/clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp +++ b/clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp @@ -173,7 +173,7 @@ const PointerToMemberData *BasicValueFactory::getPointerToMemberData( return D; } -LLVM_ATTRIBUTE_UNUSED bool hasNoRepeatedElements( +LLVM_ATTRIBUTE_UNUSED static bool hasNoRepeatedElements( llvm::ImmutableList<const CXXBaseSpecifier *> BaseSpecList) { llvm::SmallPtrSet<QualType, 16> BaseSpecSeen; for (const CXXBaseSpecifier *BaseSpec : BaseSpecList) { diff --git a/clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp b/clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp index 28d9de2973b01f..5c0df8808c2729 100644 --- a/clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp +++ b/clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp @@ -1211,18 +1211,19 @@ const arrowIndices = )<<<"; OS.str()); } -std::string getSpanBeginForControl(const char *ClassName, unsigned Index) { +static std::string getSpanBeginForControl(const char *ClassName, + unsigned Index) { std::string Result; llvm::raw_string_ostream OS(Result); OS << "<span id=\"" << ClassName << Index << "\">"; return Result; } -std::string getSpanBeginForControlStart(unsigned Index) { +static std::string getSpanBeginForControlStart(unsigned Index) { return getSpanBeginForControl("start", Index); } -std::string getSpanBeginForControlEnd(unsigned Index) { +static std::string getSpanBeginForControlEnd(unsigned Index) { return getSpanBeginForControl("end", Index); } diff --git a/clang/lib/StaticAnalyzer/Core/LoopUnrolling.cpp b/clang/lib/StaticAnalyzer/Core/LoopUnrolling.cpp index 7042f1aeb803fc..96f5d7c44baf89 100644 --- a/clang/lib/StaticAnalyzer/Core/LoopUnrolling.cpp +++ b/clang/lib/StaticAnalyzer/Core/LoopUnrolling.cpp @@ -265,8 +265,8 @@ static bool isPossiblyEscaped(ExplodedNode *N, const DeclRefExpr *DR) { llvm_unreachable("Reached root without finding the declaration of VD"); } -bool shouldCompletelyUnroll(const Stmt *LoopStmt, ASTContext &ASTCtx, - ExplodedNode *Pred, unsigned &maxStep) { +static bool shouldCompletelyUnroll(const Stmt *LoopStmt, ASTContext &ASTCtx, + ExplodedNode *Pred, unsigned &maxStep) { if (!isLoopStmt(LoopStmt)) return false; @@ -297,7 +297,7 @@ bool shouldCompletelyUnroll(const Stmt *LoopStmt, ASTContext &ASTCtx, return !isPossiblyEscaped(Pred, CounterVarRef); } -bool madeNewBranch(ExplodedNode *N, const Stmt *LoopStmt) { +static bool madeNewBranch(ExplodedNode *N, const Stmt *LoopStmt) { const Stmt *S = nullptr; while (!N->pred_empty()) { if (N->succ_size() > 1) diff --git a/clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp b/clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp index fab8e35962d751..70d5a609681790 100644 --- a/clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp +++ b/clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp @@ -158,7 +158,7 @@ RangeSet RangeSet::Factory::unite(RangeSet Original, llvm::APSInt From, } template <typename T> -void swapIterators(T &First, T &FirstEnd, T &Second, T &SecondEnd) { +static void swapIterators(T &First, T &FirstEnd, T &Second, T &SecondEnd) { std::swap(First, Second); std::swap(FirstEnd, SecondEnd); } @@ -2624,7 +2624,7 @@ EquivalenceClass::removeMember(ProgramStateRef State, const SymbolRef Old) { } // Re-evaluate an SVal with top-level `State->assume` logic. -[[nodiscard]] ProgramStateRef +[[nodiscard]] static ProgramStateRef reAssume(ProgramStateRef State, const RangeSet *Constraint, SVal TheValue) { if (!Constraint) return State; `````````` </details> https://github.com/llvm/llvm-project/pull/108759 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
