================ @@ -0,0 +1,95 @@ +//===--- IncorrectEnableSharedFromThisCheck.cpp - clang-tidy --------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#include "IncorrectEnableSharedFromThisCheck.h" +#include "clang/AST/ASTContext.h" +#include "clang/AST/DeclCXX.h" +#include "clang/AST/RecursiveASTVisitor.h" +#include "clang/ASTMatchers/ASTMatchFinder.h" +#include "clang/Basic/Specifiers.h" +#include "llvm/ADT/SmallPtrSet.h" + +using namespace clang::ast_matchers; + +namespace clang::tidy::bugprone { + +void IncorrectEnableSharedFromThisCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher(translationUnitDecl(), this); +} + +void IncorrectEnableSharedFromThisCheck::check( + const MatchFinder::MatchResult &Result) { + + class Visitor : public RecursiveASTVisitor<Visitor> { + IncorrectEnableSharedFromThisCheck &Check; + llvm::SmallPtrSet<const CXXRecordDecl *, 16> EnableSharedClassSet; + + public: + explicit Visitor(IncorrectEnableSharedFromThisCheck &Check) + : Check(Check) {} + + bool VisitCXXRecordDecl(CXXRecordDecl *RDecl) { + if (!RDecl->hasDefinition()) { + return true; + } + + if (isStdEnableSharedFromThis(RDecl)) + EnableSharedClassSet.insert(RDecl->getCanonicalDecl()); + + for (const auto &Base : RDecl->bases()) { + const auto *BaseRecord = + Base.getType()->getAsCXXRecordDecl()->getCanonicalDecl(); + const auto isStdEnableSharedFromThisBool = + isStdEnableSharedFromThis(BaseRecord); + + if (EnableSharedClassSet.contains(BaseRecord) || + isStdEnableSharedFromThisBool) { + + if (Base.getAccessSpecifier() != clang::AS_public) { + const SourceRange ReplacementRange = Base.getSourceRange(); + const std::string ReplacementString = + // Base.getType().getAsString() results in + // std::enable_shared_from_this<ClassName> or + // alias/typedefs of std::enable_shared_from_this<ClassName> + "public " + Base.getType().getAsString(); + const FixItHint Hint = FixItHint::CreateReplacement( + ReplacementRange, ReplacementString); + Check.diag(RDecl->getLocation(), + "%2 is not publicly inheriting from " + "%select{%1|'std::enable_shared_from_this',}0 " + "%select{which inherits from " + "'std::enable_shared_from_this', |}0 " + "will cause unintended behaviour " + "on 'shared_from_this'. fix this by making it public " + "inheritance", ---------------- 5chmidti wrote:
I have only seen two parts of a diagnostic be separated by a `;`, instead of using full stops with sentences `.`. E.g.,: `... 'shared_from_this'; make the inheritance public` https://github.com/llvm/llvm-project/pull/102299 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
