llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-tools-extra Author: Kazu Hirata (kazutakahirata) <details> <summary>Changes</summary> --- Full diff: https://github.com/llvm/llvm-project/pull/107490.diff 1 Files Affected: - (modified) clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp (+1-3) ``````````diff diff --git a/clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp b/clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp index 5f046c502eb383..e516b71088425b 100644 --- a/clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp +++ b/clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp @@ -67,9 +67,7 @@ static bool canAdvanceAssignment(AssignedLevel Level) { static void updateAssignmentLevel( const FieldDecl *Field, const Expr *Init, const CXXConstructorDecl *Ctor, llvm::DenseMap<const FieldDecl *, AssignedLevel> &AssignedFields) { - auto It = AssignedFields.find(Field); - if (It == AssignedFields.end()) - It = AssignedFields.insert({Field, AssignedLevel::None}).first; + auto It = AssignedFields.try_emplace(Field, AssignedLevel::None).first; if (!canAdvanceAssignment(It->second)) // fast path for already decided field. `````````` </details> https://github.com/llvm/llvm-project/pull/107490 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
