================
@@ -5274,9 +5274,17 @@ struct FormatStyle {
 
   friend std::error_code
   parseConfiguration(llvm::MemoryBufferRef Config, FormatStyle *Style,
+                     const std::vector<std::string> &StyleSearchPaths,
----------------
mydeveloperday wrote:

by putting your argument 3rd you made every instance of this function need to 
change..

you could have added it last and used a default argument, or made an overloaded 
function and a wrapper for the old one to call the new with the empty argument 
this would cut down the flux

https://github.com/llvm/llvm-project/pull/107312
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to