aganea wrote:

> Maded the suggested changes. Continuing looking into the failing tests. This 
> is my first llvm pr and I need some time to figure out the issues those are 
> indicating and replicating those locally.

I recommend that you build a Debug target, ie. `cmake -DCMAKE_BUILD_TYPE=Debug 
-DLLVM_OPTIMIZED_TABLEGEN=ON -DLLVM_ENABLE_ASSERTIONS=ON` to ease debugging in 
Visual Studio. You can then run a specific test such as: `py 
buildfolder\bin\llvm-lit.py -vv -a llvm/DebugInfo/COFF/types-data-members.ll`. 
You'll see the commands executed for that test and their command-line, so you 
will be able to reproduce them.

I think in the specific case the tests are failing because the `LF_BUILDINFO` 
is somehow emitted slightly differently from what was there before your PR. 
Either fix the test files are fix the code to match what the tests are expected.

https://github.com/llvm/llvm-project/pull/106369
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to