================ @@ -393,11 +392,9 @@ static void visitFunctionCallArguments(IndirectLocalPath &Path, Expr *Call, Path.push_back({IndirectLocalPathEntry::LifetimeBoundCall, Arg, D}); if (Arg->isGLValue()) visitLocalsRetainedByReferenceBinding(Path, Arg, RK_ReferenceBinding, - Visit, - /*EnableLifetimeWarnings=*/false); + Visit); else - visitLocalsRetainedByInitializer(Path, Arg, Visit, true, - /*EnableLifetimeWarnings=*/false); ---------------- Xazax-hun wrote:
I think the PR needs to be renamed. From a PR with the title `Remove the EnableLifetimeWarnings flag in lifetime analysis.` I'd expect either an NFC or removing a feature, not an actual bug fix. I think we should either split this up in two PRs, or rename the title to describe the bugfix aspect. https://github.com/llvm/llvm-project/pull/105884 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits