owenca wrote: > > Whilst I can understand BinPackParameters being deprecated, as its one of > > the original options I do worry a little about just how much impact such a > > deprecation might have... it needs to be completely seemless because there > > is ALOT of documentation references to its use on say stackoverflow. etc... > > One reason I suggested making the change without renaming the option was > > the level of flux the name change was having. > > I had never reviewed a similar PR (until #96804) let alone having worked on > one. Now I understand it's better to keep the option name even if it's > confusing.
Actually, we renamed boolean options before when extending them to `enum`s, e.g. [`AlwaysBreakTemplateDeclarations`](https://clang.llvm.org/docs/ClangFormatStyleOptions.html#alwaysbreaktemplatedeclarations). So I guess it depends on whether or not the old name would be confusing enough. https://github.com/llvm/llvm-project/pull/101882 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
