https://github.com/efriedma-quic approved this pull request.

LGTM

The other thing you could do is modify ScalarExprEmitter::EmitCompare... if it 
sees an overflow pattern, it passes that down as an argument to the visit of 
the add.  But I guess given the current structure of the code, that gets very 
complicated, so just storing the bit is probably easier.

https://github.com/llvm/llvm-project/pull/100272
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to