arpith-jacob marked 2 inline comments as done.
arpith-jacob added inline comments.


================
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:365
+    llvm::FunctionType *FnTy =
+        llvm::FunctionType::get(llvm::Type::getInt1Ty(CGM.getLLVMContext()),
+                                TypeParams, /*isVarArg*/ false);
----------------
ABataev wrote:
> Does it really return I1 type? Or I8?
Alexey, the runtime function is called by every worker thread.  It returns a 
'bool' that indicates if the thread has been activated in the parallel region, 
which is why I used an Int1Ty.  Please let me know if you see problems with 
this.  Thanks.


https://reviews.llvm.org/D28145



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to