DeinAlptraum wrote:

@Endilll thanks a lot for the summary! Turning this into documentation also 
sounds like a good idea.

15\. & 16. fully agree it would be nicer to go without using this `errcheck` 
functionality, and just call the conversion functions directly. Even if the 
documentation approves of our use case, imo our current usage is really just 
abuse of the functionality, and makes the code harder to understand. And as you 
said, calling it directly would allow us to remove some of the `type: ignore`s.

17\. this does not work out of the box, at least not without further changes. 
E.g. the exact example you gave there results in an error for me.

https://github.com/llvm/llvm-project/pull/101941
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to